Fix the problems mentioned in Issue #63 #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliegracie
changed the title
Passing NULL would cause the OMR_VMThread to not be linked to the language thread which may lead to crashes Signed-off-by: Charlie Gracie <charlie.gracie@gmail.com>
This allows the example / gc test code to use multiple threads and a better starting point for new languages Signed-off-by: Charlie Gracie <charlie.gracie@gmail.com>
midronij
pushed a commit
to midronij/omr
that referenced
this pull request
May 17, 2019
Block of control flow evaluators in UnaryEvaluator.cpp were moved to their correct location, in ControlFlowEvaluator.cpp. Closes: eclipse-omr#64 Signed-off-by: Jackie Midroni <jackie.midroni@mail.utoronto.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two commits in this PR resolve the problems mentioned in Issue #63.