Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix static init of vector types #6534

Merged
merged 1 commit into from
May 31, 2022
Merged

Fix static init of vector types #6534

merged 1 commit into from
May 31, 2022

Conversation

gita-omr
Copy link
Contributor

  • C++ does not guarantee any order of static initialization of variables
    defined in different compilation units
  • Make OMR::DataType::Vector128Int32 and similar variables compile time constants

jdmpapin
jdmpapin reviewed May 30, 2022
View reviewed changes
compiler/il/OMRILOps.cpp Outdated Show resolved Hide resolved
compiler/il/OMRDataTypes.hpp Outdated Show resolved Hide resolved
@gita-omr
Copy link
Contributor Author

Renamed the macro into OMR_TEMPORARY_CREATE_VECTOR_TYPE and added comments.

@gita-omr
Copy link
Contributor Author

macOS failure seems to be unrelated... https://dev.azure.com/eclipse-omr/omr/_build/results?buildId=5712&view=logs&j=aa2fd561-a338-5537-45ee-49ae22aea958&t=20ff6471-47a7-5631-6842-540dac3e3fb4&l=57968

@gita-omr
Copy link
Contributor Author

Jenkins build all

@gita-omr
Copy link
Contributor Author

The failures above seem to be happening in other PRs as well.

@babsingh
Copy link
Contributor

All failures are known:

@gita-omr
Fix static init of vector types
ba1cae5 
- C++ does not guarantee any order of static initialization of variables
defined in different compilation units
- Make OMR::DataType::Vector128Int32 and similar variables compile time constants
@gita-omr
Copy link
Contributor Author

gita-omr commented May 31, 2022 •
edited
Loading

Replaced OMR::DataType with TR::DataType for consistency.

@jdmpapin
Copy link
Contributor

Jenkins build all

@jdmpapin
Copy link
Contributor

Restarting the RISC-V tests, which failed with an infrastructure problem:

[2022-05-31T19:57:38.677Z] Cannot contact deb10-x64-1: java.lang.InterruptedException
[2022-05-31T20:28:27.423Z] Cancelling nested steps due to timeout
[2022-05-31T20:28:27.432Z] Could not connect to deb10-x64-1 to send interrupt signal to process
...
[2022-05-31T20:28:28.034Z] deb10-x64-1 was marked offline: This agent is offline because Jenkins failed to launch the agent process on it.
...
Also:   hudson.model.Computer$TerminationRequest: Termination requested at Tue May 31 16:03:12 EDT 2022 by Thread[Ping thread for channel hudson.remoting.Channel@df4780a8:deb10-x64-1,5,main] [id=380]
...
java.io.IOException: Unable to create live FilePath for deb10-x64-1
...

Jenkins build riscv

@jdmpapin
Copy link
Contributor

The Linux x86-32 and PPC64LE failures are the same as mentioned above in #6534 (comment)

@jdmpapin jdmpapin merged commit 9a4d91d into eclipse-omr:master May 31, 2022
@pshipton pshipton mentioned this pull request Jun 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdmpapin jdmpapin jdmpapin approved these changes

@vijaysun-omr vijaysun-omr Awaiting requested review from vijaysun-omr vijaysun-omr is a code owner

@Leonardo2718 Leonardo2718 Awaiting requested review from Leonardo2718

Assignees
No one assigned
Labels
comp:compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gita-omr @babsingh @jdmpapin