AArch64 macOS: Add a call to pthread_jit_write_protect_np() #6551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins build aarch64 |
|
There is no other place that call |
0xdaryl
reviewed
Jun 6, 2022
|
|
||
| #if defined(OSX) | ||
| // Regain permission for writing to the code buffer | ||
| // after calling methodTrampolineLookup() |
There was a problem hiding this comment.
Could you amend this comment to include why this is the case? i.e., that methodTrampolineLookup() may call createTrampoline() which will acquire/release write protection leaving the write permission disabled in this path.
This commit adds a call to pthread_jit_write_protect_np(0) in ARM64ImmSymInstruction::generateBinaryEncoding() for AArch64 macOS. It is needed because methodTrampolineLookup() calls createTrampoline() when necessary, and that makes the compiler thread lose the permission for writing to the code buffer. Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
|
Jenkins build aarch64 |
0xdaryl
approved these changes
Jun 6, 2022
knn-k
added a commit
to knn-k/openj9-omr
that referenced
this pull request
Jun 7, 2022
This commit adds a call to pthread_jit_write_protect_np(0) in ARM64ImmSymInstruction::generateBinaryEncoding() for AArch64 macOS. Original PR in OMR: eclipse-omr/omr#6551 Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
This was referenced Jun 7, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a call to pthread_jit_write_protect_np(0) in
ARM64ImmSymInstruction::generateBinaryEncoding() for AArch64 macOS.
It is needed because methodTrampolineLookup() calls createTrampoline()
when necessary, and that makes the compiler thread lose the permission
for writing to the code buffer.
Signed-off-by: KONNO Kazuhiro konno@jp.ibm.com