Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose a new limitOption for OpenJ9 #6842

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Expose a new limitOption for OpenJ9 #6842

merged 1 commit into from
Dec 14, 2022

Conversation

cjjdespres
Copy link
Contributor

The option processing framework now includes a limitOption function overload that allows the user to specify a particular compilation filter set.

Fixes: eclipse-openj9/openj9#15399
Signed-off-by: Christian Despres despresc@ibm.com

@cjjdespres
Expose a new limitOption for OpenJ9
4d23e85 
The option processing framework now includes a limitOption function
overload that allows the user to specify a particular compilation filter
set.

Fixes: #eclipse-openj9/openj9#15399
Signed-off-by: Christian Despres <despresc@ibm.com>
@cjjdespres
Copy link
Contributor Author

Attn @mpirvu. This is required for eclipse-openj9/openj9#16442.

I just noticed the deprecation warning in ras/Debug. Should the new limitOption function be put somewhere else?

mpirvu
mpirvu approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpirvu
Copy link
Contributor

mpirvu commented Dec 12, 2022

@dsouzai Could you please review this omr PR? Thanks

@mpirvu mpirvu mentioned this pull request Dec 12, 2022
Merged
@dsouzai
Copy link
Contributor

dsouzai commented Dec 13, 2022

jenkins build all

@dsouzai dsouzai self-assigned this Dec 13, 2022
@dsouzai
Copy link
Contributor

dsouzai commented Dec 13, 2022

Failing test is

13:46:19  test 26
13:46:19        Start 26: gctest
13:46:19  
13:46:19  26: Test command: /home/jenkins/qemu/build/qemu-riscv64 "-L" "/home/jenkins/riscv-debian/rootfs" "/home/jenkins/workspace/Build/build/fvtest/gctest/omrgctest" "--gtest_filter=gcFunctionalTest*" "--gtest_output=xml:/home/jenkins/workspace/Build/build/fvtest/gctest/omrgctest-results.xml"
13:46:19  26: Test timeout computed to be: 10000000
13:46:19  26: Note: Google Test filter = gcFunctionalTest*
13:46:19  26: [==========] Running 8 tests from 1 test case.
13:46:19  26: [----------] 8 tests from gcFunctionalTest/GCConfigTest
13:46:19  Terminated
13:46:20  script returned exit code 143

Given that this is just some refactoring code in the JIT, I don't think this is the cause of the failure.

@dsouzai
Copy link
Contributor

dsouzai commented Dec 13, 2022

jenkins build riscv

@mpirvu
Copy link
Contributor

mpirvu commented Dec 14, 2022

All tests have passed

@dsouzai dsouzai merged commit 9c865e1 into eclipse-omr:master Dec 14, 2022
@AlexeyKhrabrov AlexeyKhrabrov mentioned this pull request Dec 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpirvu mpirvu mpirvu approved these changes

@dsouzai dsouzai dsouzai approved these changes

@0xdaryl 0xdaryl Awaiting requested review from 0xdaryl 0xdaryl is a code owner

@mstoodle mstoodle Awaiting requested review from mstoodle mstoodle is a code owner

Assignees

@dsouzai dsouzai

Labels
comp:compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add options to bypass JITServer AOT cache per method
3 participants
@cjjdespres @mpirvu @dsouzai