RISC-V: fix docker image creation for CI cross-builds #7261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes Dockerfile creating image for RISC-V CI builds. The
problem was that URL libfakeroot and libfakechroot was no longer valid.
It pointed to Debian ports archive, but meanwhile RISC-V architecture
became "officially" supported (will be once Trixie is out).
It is not clear to me why Dockerfile downloaded and extracted RISC-V
versions of libfakeroot and libfakechroot at all. However, I had been
successfully building sysroots for OMR and/or OpenJ9 compilations using
mmdebstrap --mode=fakeroot --variant=extract
without need of RISC-V libfakeroot and libfakechroot. So this commit
removes download and manual installation of them and uses
--variant=extract to build sysroot. In addition it uses new ("official")
Debian archives to build the sysroot. This way the aforementioned
problem with outdated URLs should be fixed for good.
Fixes eclipse-omr#7256.
janvrany
requested review from
charliegracie,
mstoodle and
0xdaryl
as code owners
|
jenkins build riscv |
|
RISC-V build failed due to timeout in |
babsingh
approved these changes
Feb 9, 2024
|
OSX failure is unrelated and known: #7181. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes Dockerfile creating image for RISC-V CI builds. The problem was that URL libfakeroot and libfakechroot was no longer valid. It pointed to Debian ports archive, but meanwhile RISC-V architecture became "officially" supported (will be once Trixie is out).
It is not clear to me why Dockerfile downloaded and extracted RISC-V versions of libfakeroot and libfakechroot at all. However, I had been successfully building sysroots for OMR and/or OpenJ9 compilations using
without need of RISC-V libfakeroot and libfakechroot. So this commit removes download and manual installation of them and uses --variant=extract to build sysroot. In addition it uses new ("official") Debian archives to build the sysroot. This way the aforementioned problem with outdated URLs should be fixed for good.
Fixes #7256.