Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 32bit allocator flags #7285

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Conversation

tajila
Copy link
Contributor

@tajila tajila commented Mar 19, 2024

Introduce a mechanism to set flags for the 32bit allocator.

Use the new mechanism to toggle the vmem mode to tmp file backed vmem.

@tajila tajila force-pushed the master branch 12 times, most recently from 809fd3a to 526606c Compare March 21, 2024 21:52
@tajila tajila marked this pull request as ready for review March 21, 2024 21:57
@tajila
Copy link
Contributor Author

tajila commented Mar 21, 2024

@babsingh please review these changes

Copy link
Contributor

@babsingh babsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits. which new feature will be supported by these changes?

port/common/omrmem32helpers.c Outdated Show resolved Hide resolved
include_core/omrport.h Outdated Show resolved Hide resolved
@tajila
Copy link
Contributor Author

tajila commented Mar 22, 2024

which new feature will be supported by these changes?

Currently, this will enable us to study the performance impacts of differing vmem modes. Longer term we would like to explore disclaiming 32bit memory at runtime and in CRIU C/R. Additionally, the ability to set 32bit allocator flags may be helpfull if we want to toggle the behaviour for special cases (eg. using vthreads or not).

@babsingh
Copy link
Contributor

jenkins build all

@babsingh
Copy link
Contributor

https://ci.eclipse.org/omr/job/PullRequest-zos_390-64/4363/console

11:48:34  ERROR CCN3022 /u/user1/workspace/Build/port/common/omrportcontrol.c:331   "mem32BitFlags" is not a member of "struct OMRPortPlatformGlobals".
11:48:34  CCN0793(I) Compilation failed for file /u/user1/workspace/Build/port/common/omrportcontrol.c.  Object file not created.

Introduce a mechanism to set flags for the 32bit allocator.

Use the new mechanism to toggle the vmem mode to tmp file backed vmem.

Signed-off-by: Tobi Ajila <atobia@ca.ibm.com>
@tajila
Copy link
Contributor Author

tajila commented Mar 22, 2024

I missed a header definition.

Its fixed now.

@babsingh
Copy link
Contributor

jenkins build all

@babsingh
Copy link
Contributor

@babsingh babsingh merged commit b7d9218 into eclipse-omr:master Mar 22, 2024
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants