Correct typos mentioning classDepthAndFlags field #7330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code in OMR supports the JIT compiler in generating IL to access the J9Class field classDepthAndFlags field in the downstream OpenJ9 project. In many cases, that code incorrectly refers to the field as classAndDepthFlags. This commit adds new duplicate definitions of the methods and enum values that correct the name. Once the downstream project removes references to the obsolete methods, the obsolete definitions will be removed.
|
@0xdaryl, may I ask you to review this change? |
|
Jenkins build all |
0xdaryl
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code in OMR supports the JIT compiler in generating IL to access the
J9ClassfieldclassDepthAndFlagsin the downstream OpenJ9 project. In many cases, that compiler code incorrectly refers to the field asclassAndDepthFlags.This commit adds new duplicate definitions of the methods and enum values to use the correct name. Once the downstream project removes references to the obsolete methods, the obsolete definitions will be removed.