Hide details of IL to test for array type class and remove unused symbol references #7334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 27, 2024
Duplicate symbols that were based on the incorrect field name, classAndDepthFlags, rather than the correct name, classDepthAndFlags, are no longer referenced in downstream projects. This change removes them. Signed-off-by: Henry Zongaro <zongaro@ca.ibm.com>
The downstream OpenJ9 project defines a new method, TR_VMBase::testIsClassArrayType, that generates IL to tests whether a class is an array class. Change code that generated IL that loaded classDepthAndFlags field itself to call testIsClassArrayType instead to hide at least some of the J9-specific details. Also, generate a comparison of the result of the IL produced by testIsClassArrayType with zero, rather than comparing with the array class flag. A comparison with zero is expected to be preferred on most platforms. Signed-off-by: Henry Zongaro <zongaro@ca.ibm.com>
hzongaro
force-pushed
the
hide-load-of-classDepthAndFlags
branch
from
5f83203
to
f757802
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes some
J9_PROJECT_SPECIFICcode in Loop Versioner to use the methodtestIsClassArrayTypeto hide some of the lower-level details of generating IL to determine whether a class represents an array type class.Also, a previous pull request — #7330 — introduced duplicate enum constant and method names for accessing the
classDepthAndFlagsfield ofj9classin the downstream OpenJ9 project. Now that the old names are no longer used in the downstream project, those duplicate definitions can be removed.