Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide details of IL to test for array type class and remove unused symbol references #7334

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Hide details of IL to test for array type class and remove unused symbol references #7334

merged 2 commits into from
Jul 5, 2024

Commits on Jul 3, 2024

  1. Remove unused symbols referring to classAndDepthFlags 

    Duplicate symbols that were based on the incorrect field name,
classAndDepthFlags, rather than the correct name, classDepthAndFlags,
are no longer referenced in downstream projects.  This change removes
them.

Signed-off-by:  Henry Zongaro <zongaro@ca.ibm.com>
    @hzongaro
    hzongaro committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    1dd236b View commit details
    Browse the repository at this point in the history

  2. Use testIsClassArrayType to generate IL to test for array type 

    The downstream OpenJ9 project defines a new method,
TR_VMBase::testIsClassArrayType, that generates IL to tests whether a
class is an array class.  Change code that generated IL that loaded
classDepthAndFlags field itself to call testIsClassArrayType instead to
hide at least some of the J9-specific details.

Also, generate a comparison of the result of the IL produced by
testIsClassArrayType with zero, rather than comparing with the array
class flag.  A comparison with zero is expected to be preferred on most
platforms.

Signed-off-by:  Henry Zongaro <zongaro@ca.ibm.com>
    @hzongaro
    hzongaro committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    a62b60b View commit details
    Browse the repository at this point in the history