Define isPowerOf2 utility methods for unsigned #7377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are isPowerOf2 methods defined in Bit.hpp for int32_t and int64_t values. This change defines new isPowerOf2 methods for values of type uint32_t and uint64_t. Also added Doxygen comments for the various isPowerOf2 methods. Signed-off-by: Henry Zongaro <zongaro@ca.ibm.com>
hzongaro
force-pushed
the
isPowerOf2-unsigned
branch
from
8c1f7ff
to
2b5fd40
Compare
|
@0xdaryl, may I ask you to review this change? |
|
Jenkins build all |
0xdaryl
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are
isPowerOf2methods defined inBit.hppforint32_tandint64_tvalues. This change defines newisPowerOf2methods for values of typeuint32_tanduint64_t.Also added Doxygen comments for the various
isPowerOf2methods.This change doesn't introduce any uses of these methods in OMR, but I will be able to take advantage of them in a downstream project.