Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Change arraycmp length child to 64 bits" #7380

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Revert "Change arraycmp length child to 64 bits" #7380

merged 1 commit into from
Jun 14, 2024

Conversation

hzongaro
Copy link
Contributor

Reverts #7313

@hzongaro
Copy link
Contributor Author

@pshipton, may I ask you to merge this reversion?

@0xdaryl 0xdaryl self-assigned this Jun 14, 2024
@0xdaryl
Copy link
Contributor

0xdaryl commented Jun 14, 2024

Some issues encountered on 32-bit platforms. Reverting while investigating.

@0xdaryl
Copy link
Contributor

0xdaryl commented Jun 14, 2024

@hzongaro : Peter can't merge this PR. I can await his review before merging unless you direct me otherwise.

@0xdaryl 0xdaryl merged commit 4c74f94 into master Jun 14, 2024
9 checks passed
@hzongaro
Copy link
Contributor Author

Peter can't merge this PR. I can await his review before merging unless you direct me otherwise.

Oops! Sorry for my confusion. And, thank you.

@hzongaro hzongaro deleted the revert-7313-arraycmp-64 branch June 14, 2024 20:27
@Spencer-Comin Spencer-Comin mentioned this pull request Jun 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshipton pshipton pshipton approved these changes

@0xdaryl 0xdaryl 0xdaryl approved these changes

@fjeremic fjeremic Awaiting requested review from fjeremic

@knn-k knn-k Awaiting requested review from knn-k knn-k is a code owner

@vijaysun-omr vijaysun-omr Awaiting requested review from vijaysun-omr vijaysun-omr is a code owner

@mstoodle mstoodle Awaiting requested review from mstoodle mstoodle is a code owner

Assignees

@0xdaryl 0xdaryl

Labels
arch:aarch64 arch:power arch:x86 arch:z comp:compiler comp:test comp:tril
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hzongaro @0xdaryl @pshipton