Fix null restricted array related issues for value types #7452
Conversation
a7ehuo
force-pushed
the
PR-valuetypes-null-restricted-array
branch
from
9796e8e
to
8075e57
Compare
|
@hzongaro May I ask you to review this change? Thank you very much! This PR is created as a draft and marked as Since this PR depends on eclipse-openj9/openj9#20112, it should be review along with eclipse-openj9/openj9#20112. |
There was a problem hiding this comment.
Looking at these changes in isolation, I think they look good. Just a few very minor comments. I'll come back again after reviewing OpenJ9 pull request eclipse-openj9/openj9#20112.
Also, may I ask you to expand on the description for commit 6e2377c to describe what getNullRestrictedArrayClassFromComponentClass is expected to do, and also the description for commit 0353738 to indicate why the name change is needed?
|
May I also ask you to remove the Markdown from the commit comments? |
Add front end getNullRestrictedArrayClassFromComponentClass that retrieves the nullRestrictedArrayClass pointer from the array component class if it exist. Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
a7ehuo
force-pushed
the
PR-valuetypes-null-restricted-array
branch
from
8075e57
to
a697231
Compare
a7ehuo
changed the title
Rename isArrayCompTypePrimitiveValueType to isArrayNullRestricted. Whether or not an array is null restricted is no longer decided by array component type but by the J9ClassArrayIsNullRestricted flag in array class. Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
Load the source array and the destination array from the saved temp instead of commoning the original nodes incorrectly across blocks. Related: eclipse-openj9/openj9#19913, eclipse-openj9/openj9#19914 Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
a7ehuo
force-pushed
the
PR-valuetypes-null-restricted-array
branch
from
a697231
to
833607b
Compare
|
@hzongaro All comments have been addressed in the latest commits. Ready for another review. Thank you! Please note that I have rebased this PR to the latest master branch and this PR requires coordinated merge with eclipse-openj9/openj9#20112. |
There was a problem hiding this comment.
Looks good. I will wait for eclipse-openj9/openj9#20112 to be ready before I merge this pull request.
|
Jenkins build all |
|
Testing of this pull request was successful, along with testing of the downstream dependent pull request eclipse-openj9/openj9#20112. Merging. |
(1) Add front end
getNullRestrictedArrayClassFromComponentClassto retrieve null restricted array class(2) Rename
isArrayCompTypePrimitiveValueTypetoisArrayNullRestrictedto reflect the updated logic(3) Fix array load in
transformNullRestrictedArrayCopyDepends on
Related: eclipse-openj9/openj9#19914, eclipse-openj9/openj9#19913