Provided an error code for "compilationAotHasInvokeSpecialInterface" to retry as JIT compilation #11018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmanElsaban
changed the title
|
@mpirvu Ready for review. Thanks. |
mpirvu
reviewed
Oct 28, 2020
runtime/compiler/control/rossa.h
Outdated
| @@ -86,6 +86,7 @@ typedef enum { | |||
| compilationStreamVersionIncompatible = compilationFirstJITServerFailure+3, | |||
| compilationStreamInterrupted = compilationFirstJITServerFailure+4, | |||
| #endif /* defined(J9VM_OPT_JITSERVER) */ | |||
| compilationAotHasInvokeSpecialInterface = 60, | |||
There was a problem hiding this comment.
This is going to be harder to maintain if we add or delete JITServer related failures. Maybe add a compilationLastJITServerFailure and start counting from there.
Even better, don't add any number; let the compiler do the counting. Just add a comment with the supposed value.
…essException Caught the exception "AOTHasInvokeSpecialInInterface" in processException to retry the compilation as a JIT compilation. issue: eclipse-openj9#11011 Signed-off-by: Eman Elsabban <eman.elsaban1@gmail.com>
EmanElsaban
force-pushed
the
invokeSpecial
branch
from
8f34411
to
dcc96ca
Compare
mpirvu
approved these changes
Oct 29, 2020
|
jenkins test sanity all jdk11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caught the exception "AOTHasInvokeSpecialInInterface", which is thrown when a method that has an invoke special in an interface is AOT Compiled, in processException to retry the compilation as a JIT compilation.
issue: #11011
Signed-off-by: Eman Elsabban eman.elsaban1@gmail.com