Get special-case invokeinterface receiver early #5500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 7295e2c the JIT compiler was modified so that it could generate IL for "improper" invokeinterface bytecode instructions, i.e. those targeting private methods or methods of Object. For these invocations, the dispatch does not naturally perform the type check required for invokeinterface, so an explicit type check is generated ahead of the call. This type check needs the receiver of the call, which until now has been read from the resulting call node. The problem is that it's possible that the node is no longer a call by the time the type check is generated, e.g. in the case of a call to Object.getClass(), the call becomes aloadi <javaLangClassFromClass> during genInvokeDirect(). The receiver is now read from the stack before calling genInvokeDirect() or genInvokeWithVFTChild() so that the type check will be unaffected by any such transformations. Signed-off-by: Devin Papineau <devinmp@ca.ibm.com>
|
@andrewcraik @cathyzhyi Can one of you review this? |
|
LGTM |
|
Jenkins test sanity zlinux jdk8 |
|
Jenkins test extended win jdk11 |
|
Jenkins test sanity osx jdk12 |
|
Is this ok to merge now? |
|
@fjeremic Can you give this a second set of eyes and merge it? @cathyzhyi has already reviewed and approved it. |
fjeremic
approved these changes
Apr 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 7295e2c the JIT compiler was modified so that it could generate IL for "improper"
invokeinterfacebytecode instructions, i.e. those targeting private methods or methods ofObject. For these invocations, the dispatch does not naturally perform the type check required forinvokeinterface, so an explicit type check is generated ahead of the call. This type check needs the receiver of the call, which until now has been read from the resulting call node. The problem is that it's possible that the node is no longer a call by the time the type check is generated, e.g. in the case of a call toObject.getClass(), the call becomesaloadi <javaLangClassFromClass>duringgenInvokeDirect().The receiver is now read from the stack before calling
genInvokeDirect()orgenInvokeWithVFTChild()so that the type check will be unaffected by any such transformations.