Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable more Ruff rules (incl. those ignored previously) #779

Merged
merged 12 commits into from
Dec 23, 2023
Merged

Enable more Ruff rules (incl. those ignored previously) #779

merged 12 commits into from
Dec 23, 2023

Conversation

akx
Copy link
Contributor

@akx akx commented Dec 23, 2023

No description provided.

@akx akx marked this pull request as ready for review December 23, 2023 17:07
@akx
Copy link
Contributor Author

akx commented Dec 23, 2023

🔔 @cclauss 😁

@PierreF
Copy link
Contributor

PierreF commented Dec 23, 2023

I think there will be a conflict between this PR and #776 . #776 is currently mergeable (no conflict), so it should probably be better to merge #776 first. @akx, you were asked for a review on that PR that why I wait to merge it.

@akx akx marked this pull request as draft December 23, 2023 20:30
@akx

This comment was marked as outdated.

Sign in to view
@akx akx marked this pull request as ready for review December 23, 2023 20:42
@akx
Copy link
Contributor Author

akx commented Dec 23, 2023

@PierreF Rebased, ready for review.

@PierreF PierreF merged commit 933699a into eclipse-paho:master Dec 23, 2023
10 checks passed
@PierreF
Copy link
Contributor

PierreF commented Dec 23, 2023

Thank ! That's a good cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akx @PierreF