Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated methods from Model API #748

Closed
abrokenjester opened this issue Feb 2, 2017 · 0 comments
Closed

Remove deprecated methods from Model API #748

abrokenjester opened this issue Feb 2, 2017 · 0 comments
Assignees
@abrokenjester
Labels
📶 enhancement issue is a new feature or improvement M1 Fixed in milestone 1 ⛔ Not backwards compatible A change that breaks backwards compatibility and needs a major release
Milestone
3.0.0

Comments

@abrokenjester
Copy link
Contributor

There's a lot of deprecated methods in the Model API that have been so since at least Sesame 2.8, possibly longer. The next major release is a good opportunity to remove some of the clutter.
@abrokenjester abrokenjester added this to the 3.0 milestone Feb 2, 2017
josephw added a commit to josephw/rdf4j that referenced this issue Feb 22, 2017
@josephw
Issue eclipse-rdf4j#748: Switch to Models methods for testing.
91e5b73 
Follow the suggestion of the deprecation warning.

Signed-off-by: Joseph Walton <joe@kafsemo.org>
josephw added a commit to josephw/rdf4j that referenced this issue Feb 22, 2017
@josephw
Issue eclipse-rdf4j#748: Switch to IRIs in tests.
8ee80cd 
Use IRIs rather than URIs to avoid deprecated methods.

Signed-off-by: Joseph Walton <joe@kafsemo.org>
josephw added a commit to josephw/rdf4j that referenced this issue Feb 22, 2017
@josephw
Issue eclipse-rdf4j#748: Remove deprecated methods from Model.
702fdcb 
Signed-off-by: Joseph Walton <joe@kafsemo.org>
josephw added a commit to josephw/rdf4j that referenced this issue Feb 22, 2017
@josephw
Issue eclipse-rdf4j#748: Remove tests for deleted methods.
8a45987 
These methods on Model have now been removed. Remove the tests;
anything should be tested on the Models utility methods.

Signed-off-by: Joseph Walton <joe@kafsemo.org>
@josephw josephw mentioned this issue Feb 22, 2017
Merged
abrokenjester added a commit that referenced this issue Feb 28, 2017
@abrokenjester
Merge pull request #769 from josephw/issues/#748-clean-up-tests-using…
6df9a5f 
…-deprecated-methods

Clean up tests using deprecated methods
catch-point pushed a commit to catch-point/rdf4j that referenced this issue Apr 19, 2017
@josephw
Issue eclipse-rdf4j#748: Switch to Models methods for testing.
496ec1f 
Follow the suggestion of the deprecation warning.

Signed-off-by: Joseph Walton <joe@kafsemo.org>
catch-point pushed a commit to catch-point/rdf4j that referenced this issue Apr 19, 2017
@josephw
Issue eclipse-rdf4j#748: Switch to IRIs in tests.
1ad042d 
Use IRIs rather than URIs to avoid deprecated methods.

Signed-off-by: Joseph Walton <joe@kafsemo.org>
@barthanssens barthanssens added the 📶 enhancement issue is a new feature or improvement label Nov 20, 2018
@abrokenjester abrokenjester added the ⛔ Not backwards compatible A change that breaks backwards compatibility and needs a major release label Jan 13, 2019
@abrokenjester abrokenjester self-assigned this Jun 22, 2019
abrokenjester added a commit that referenced this issue Jun 22, 2019
@abrokenjester
GH-748 cleanup of deprecated methods
1a01f36
@abrokenjester abrokenjester mentioned this issue Jun 22, 2019
Merged
abrokenjester pushed a commit that referenced this issue Jun 22, 2019
Merge pull request #1460 from eclipse/issues/GH-748-remove-model-methods
207688a 
GH-748 cleanup of deprecated methods in Model
@abrokenjester abrokenjester added the M1 Fixed in milestone 1 label Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abrokenjester abrokenjester

Labels
📶 enhancement issue is a new feature or improvement M1 Fixed in milestone 1 ⛔ Not backwards compatible A change that breaks backwards compatibility and needs a major release
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@abrokenjester @barthanssens