Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

Improve ThingHandler API to allow easy addition of Channels #4950

Closed
kaikreuzer opened this issue Jan 19, 2018 · 1 comment · Fixed by #5025
Closed

Improve ThingHandler API to allow easy addition of Channels #4950

kaikreuzer opened this issue Jan 19, 2018 · 1 comment · Fixed by #5025
Labels
Core enhancement

Comments

@kaikreuzer
Copy link
Contributor

In our thing modelling FAQs, we suggest as (4) to dynamically add channels to a Thing within the handler.
As discussed here, this is currently a bit cumbersome, though, as there isn't an easy way to construct a channel from a channel type, which means that the best code I could come up with is this.

We should simplify this either by improving the ChannelBuilder or possibly by directly supporting it in the ThingBuilder (not sure yet, what is the better option).
@kaikreuzer kaikreuzer mentioned this issue Jan 19, 2018
Closed
@sjsf sjsf mentioned this issue Feb 1, 2018
Merged
@sjsf
Copy link
Contributor

sjsf commented Feb 1, 2018

Another victim interested party: openhab/openhab2-addons#2859 (Denon/Marantz binding)

@jwveldhuis jwveldhuis mentioned this issue Feb 1, 2018
Merged
sjsf pushed a commit to sjsf/smarthome that referenced this issue Feb 2, 2018
Provide preconfigured ChannelBuilders
3f20b1a 
...for any given ChannelTypeUID in the ThingHandlerCallback and
in the BaseThingHandler corrrespondingly.

fixes eclipse-archived#4950
Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
@sjsf sjsf mentioned this issue Feb 2, 2018
Merged
sjsf pushed a commit to sjsf/smarthome that referenced this issue Feb 2, 2018
Provide preconfigured ChannelBuilders
b554b4c 
...for any given ChannelTypeUID in the ThingHandlerCallback and
in the BaseThingHandler correspondingly.

fixes eclipse-archived#4950
Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
sjsf pushed a commit to sjsf/smarthome that referenced this issue Feb 6, 2018
Provide preconfigured ChannelBuilders
bb2aafb 
...for any given ChannelTypeUID in the ThingHandlerCallback and
in the BaseThingHandler correspondingly.

fixes eclipse-archived#4950
Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
sjsf pushed a commit to sjsf/smarthome that referenced this issue Feb 6, 2018
Provide preconfigured ChannelBuilders
acdee3f 
...for any given ChannelTypeUID in the ThingHandlerCallback and
in the BaseThingHandler correspondingly.

fixes eclipse-archived#4950
Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
sjsf pushed a commit to sjsf/smarthome that referenced this issue Feb 9, 2018
Provide preconfigured ChannelBuilders
df41b72 
...for any given ChannelTypeUID in the ThingHandlerCallback and
in the BaseThingHandler correspondingly.

fixes eclipse-archived#4950
Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
kaikreuzer pushed a commit that referenced this issue Mar 2, 2018
@kaikreuzer
Provide preconfigured ChannelBuilders (#5025)
1a0d041 
* Provide preconfigured ChannelBuilders

...for any given ChannelTypeUID in the ThingHandlerCallback and
in the BaseThingHandler correspondingly.

fixes #4950
Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provide preconfigured ChannelBuilders sjsf/smarthome
2 participants
@sjsf @kaikreuzer