This repository has been archived by the owner on May 7, 2020. It is now read-only.
[Homematic] Restrict Bin/XmlRpcServer to specified callback host address #5928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open Server on host specified in the property "callbackHost" instead of opening it without specification. This will prevent conflicts on machines which provide multiple network interfaces. Further improvements for stability of the communication between binding and gateway: * Improved error logging of ConnectionTrackerThread * Synchronized AbstractHomematicGateway's start/stopServers to prevent starting of new servers while previous operation is still blocking REMARK: Actually this change was already in-place on openhab (see openhab/openhab2-addons@357036c#diff-34d39d6e0ca3033b15f157f32c370cac), but it was accidentially not included when moving the binding to the eclipse smarthome project Signed-off-by: Michael Reitler <michael.reitler@telekom.de>
htreu
approved these changes
Jul 18, 2018
|
Thanks @htreu |
kaikreuzer
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open Server on host specified in the property "callbackHost" instead of
opening it without specification. This will prevent conflicts on machines which provide multiple network interfaces.
Further improvements for stability of the communication between binding and gateway:
REMARK:
Actually this change was already in-place on openhab (see openhab/openhab2-addons@357036c#diff-34d39d6e0ca3033b15f157f32c370cac),
but it was accidentially not included when moving the binding to the eclipse smarthome project
Signed-off-by: Michael Reitler michael.reitler@telekom.de