This repository has been archived by the owner on May 7, 2020. It is now read-only.
Setting stop timeout to 0 in order to avoid blocking the component deactivation #6636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…activation. Also fixed setting of keepAliveTimeout, improved thread naming and logging. Signed-off-by: Kai Kreuzer <kai@openhab.org>
|
#6632 looks looks like a Jetty bug to me - when the client is stopped, it finds jobs being executed in the threads, so it waits for the stop timeout for them to finish, what they never do (these are lambdas coming from EatWhatYouKill lifecycle management. This PR sets the stop timeout to 0. This lets the client ignore the running jobs and after its termination, the threadpool is clean as well (so we do not have any hanging threads left). |
kaikreuzer
added a commit
to kaikreuzer/smarthome
that referenced
this pull request
Dec 11, 2018
…activation. (eclipse-archived#6636) Also fixed setting of keepAliveTimeout, improved thread naming and logging. Signed-off-by: Kai Kreuzer <kai@openhab.org>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/oh2-4-0-m-milestone-testing-summary/59035/38 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed setting of keepAliveTimeout, improved thread naming and logging.
Fixes #6632
Signed-off-by: Kai Kreuzer kai@openhab.org