--redeploy ignores -D system prooperties

[javadevmtl]

Using vertx 3.4.1 see my thread here: https://groups.google.com/forum/?fromgroups=#!topic/vertx/fjlsWFqMiJk

I looked around: https://github.com/eclipse/vert.x/blob/65a1050b0922de38329cdbe90c5ecd8094a93a04/src/main/java/io/vertx/core/impl/launcher/commands/RunCommand.java

If I understand it correctly...
If --redeploy then initializeRedeployment() which calls startAsBackgroundApplication

There's a check here

if (systemProperties != null) {
      args.addAll(systemProperties.stream().map(s -> "-D" + s).collect(Collectors.toList()));
    }

But It seems that the properties are null at this point...

Calling System.getProperties().list(System.out); in our own verticle the passed in -D properties are gone only the java one show up. Removing --redeploy everything works as expected.

[cescoffier]

It's because the redeploy use a forked process. To pass parameters to the application in redeploy mode, use --java-opts="-conf=... -Dfoo-bar

[javadevmtl]

Ok that works, maybe it can be mentioned in the redeployment docs?

Btw -conf doesn't need to be part --java-opts

This works...

run {
args = [
'run', mainVerticleName,
"--redeploy=$watchForChange",
"--launcher-class=$mainClassName",
"--java-opts=-Dfoo=bar",
"--on-redeploy=$doOnChange",
'-conf', 'src/main/conf/config.json'
]
}

[cescoffier]

You are absolutely right. I was pretty sure it was documented, about a closer look just broken my "dreams". Gonna open a PR immediately. Please keep this issue open as I'm going to use it to track progress.

[cescoffier]

@javadevmtl can you review #1961 and tell me if it gives enough details?

[javadevmtl]

Done.

[cescoffier]

Thanks @javadevmtl !

[javadevmtl]

Just curious. There's a main java process that receives the properties and then forks a process. Can those properties not be passed to it instead of using --java-opts?

[cescoffier]

On 8 May 2017, at 15:16, javadevmtl ***@***.***> wrote: Just curious. There's a main java process that receives the properties and then forks a process. Can those properties not be passed to it instead of using --java-opts?

It’s hard to find which properties need to be passed to the child process. However, system properties passed using -D (as command line parameter, so after the “run” command) should be propagated to the child process. For instance: ``` java -cp target/hello-1.0-SNAPSHOT.jar io.vertx.hello.MyLauncher run io.vertx.hello.HelloVerticle --redeploy="src/main/java/**/*" -DPROP="hello" --conf=conf.json …. ``` This command propagates the `conf` param and the `PROP` system property to the child process. However, this won’t work: java -DPROP=“hello” -cp target/hello-1.0-SNAPSHOT.jar io.vertx.hello.MyLauncher run io.vertx.hello.HelloVerticle --redeploy="src/main/java/**/*" -DPROP="hello" --conf=conf.json ….

…

— You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1960 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAYjfTm9T4Q6WHScbJI_lG-SdYkBO3iNks5r3xWZgaJpZM4NNO_m>.

[cescoffier]

Fixed in #1961