Fixes intermittent failure in io.vertx.test.core.Http2ClientTest.test100Continue #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…100Continue java.lang.AssertionError: expected:<0> but was:<1> at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:834) at org.junit.Assert.assertEquals(Assert.java:645) at org.junit.Assert.assertEquals(Assert.java:631) at io.vertx.test.core.AsyncTestBase.assertEquals(AsyncTestBase.java:235) at io.vertx.test.core.Http2ClientTest.lambda$test100Continue$170(Http2ClientTest.java:1293) We know the body handler should be called after both the request handler and the continue handler have been called. But we don't know which one will be called first: in Http2ServerConnection.onHeadersRead, we write continue headers to the response then schedule the request handler execution. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We know the body handler should be called after both the request handler and the continue handler have been called.
But we don't know which one will be called first: in Http2ServerConnection.onHeadersRead, we write continue headers to the response then schedule the request handler execution.