AsyncFileImpl.writeInternal swallows op failures #1989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ures Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
changed the title
vietj
reviewed
May 17, 2017
pom.xml
Outdated
| @@ -204,7 +204,12 @@ | |||
| <version>${tcnative.version}</version> | |||
| <scope>test</scope> | |||
| </dependency> | |||
|
|
|||
| <dependency> | |||
There was a problem hiding this comment.
we can't have this dependency added, otherwise it means we need to file a CQ for 3.4.2
Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
|
Ok. I just pushed a commit so that we only keep the fix.
2017-05-17 8:17 GMT+02:00 Julien Viet <notifications@github.com>:
… ***@***.**** commented on this pull request.
------------------------------
In pom.xml
<#1989 (comment)>:
> @@ -204,7 +204,12 @@
<version>${tcnative.version}</version>
<scope>test</scope>
</dependency>
-
+ <dependency>
we can't have this dependency added, otherwise it means we need to file a
CQ for 3.4.2
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1989 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABblticeHIKPWAtSKH7znnDu84fNp8NAks5r6pDggaJpZM4NdDQl>
.
|
|
👍 let's keep things that way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1967