Bulk upload models with review points. #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nagavijay Sivakumar <nagavijay.sivakumar@bosch-si.com> Bulk upload error handling and improvements. Closes eclipse-vorto#68 Signed-off-by: Nagavijay Sivakumar <nagavijay.sivakumar@bosch-si.com>
| * @param fileName | ||
| * @return result about information of the uploaded content and the upload handle. | ||
| */ | ||
| List<UploadModelResult> uploadMultipleModels(String fileName); |
There was a problem hiding this comment.
Why can't we re-use the existing upload(byte[] content, String fileName) ?
I would assume that the method implementation could use 2 different handle strategies based on the fileName type ,one for zip with multiple files and one for a single model file.
There was a problem hiding this comment.
Yes. The existing single file upload validations criteria are different which is not suitable for multiple model upload and also to avoid multiple conditional checks for single and multiple upload files.
Currently the Toolset editor doesn't have multiple upload UI and maybe in future if we have plan to support in toolset editor then we could merge those interfaces into one.
added 3 commits
April 29, 2016 19:49
Signed-off-by: Nagavijay Sivakumar <nagavijay.sivakumar@bosch-si.com> Bulk upload error handling and improvements. Closes eclipse-vorto#68 Signed-off-by: Nagavijay Sivakumar <nagavijay.sivakumar@bosch-si.com> Checkin Button moved to top and error message changes. Signed-off-by: Nagavijay Sivakumar <nagavijay.sivakumar@bosch-si.com>
https://github.com/bsinno/vorto.git into feature/bulk_upload_models Conflicts: server/repo/repo-ui/src/main/resources/static/js/app.js server/repo/repo-ui/src/main/resources/static/js/controllers.js server/repo/repo-ui/src/main/resources/static/partials/upload-template.html
Signed-off-by: Nagavijay Sivakumar <nagavijay.sivakumar@bosch-si.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bulk upload models with review points implemented.
Closes #68