-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bad error Message from INTValueConverter #2576
Comments
"Bad" Conversion is done by |
i am not sure if this should be fixed on ValueConverter side or on SyntaxErrorMessageProvider side |
I'd say in the value converter. It is closer to the problem implementation-wise. I see |
as i said: the value converter message is fine,
so we should not attach the root cause there? here is what the parser does
|
any hints? |
I think the vce's message should win if it's not the default message. |
hmmm a valueconverter exception is constructed as follows
=> the exception message contains the causes message if there was no explicit message |
Meh. Comparing the causes' message with the value converters message doesn't make any sense in |
When Xtext cannot parse an int literal, it gives a meaningless "For input string: ..." error message, although the value converter exception carries a proper error message with it. See also https://github.com/eclipse/xtext-core/issues/247.
* Fix binding to ISyntaxErrorMessageProvider * Improve error message for large integer values When Xtext cannot parse an int literal, it gives a meaningless "For input string: ..." error message, although the value converter exception carries a proper error message with it. See also https://github.com/eclipse/xtext-core/issues/247.
@miklossy do you plan to work on this issue? |
Not in the near future. I will unset the milestone. |
This error message is a really great way to waste a morning debugging the parser and pulling at your hair when you change some rule names in the grammar and forget that somebody wrote custom value converters 2 years ago. |
pull request still is welcome |
a failing INTValueConverter leeds to following error message
For input string: "999999999999999999999"
it would be nice to have better error messages
The text was updated successfully, but these errors were encountered: