-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possibility to configure the encoding in the IResourcesSetupUtil.createTempFile #2844
Labels
Milestone
Comments
What about the other createFile methods |
We can also extend the IResourcesSetupUtil.createFile method with an additional encoding parameter. |
Change or add additional? The first would break compatibility |
Add! |
I can implement this on friday, if you agree. |
Thanks you @hannesN ! |
miklossy
added a commit
that referenced
this issue
Jul 10, 2024
- Extend the IResourcesSetupUtil class by a createTempFile method that accepts a charset as a parameter to be able to configure the encoding. Signed-off-by: miklossy <miklossy@itemis.de>
miklossy
added a commit
that referenced
this issue
Jul 11, 2024
- Extend the IResourcesSetupUtil class by a createTempFile method that accepts a charset as a parameter to be able to configure the encoding. Signed-off-by: miklossy <miklossy@itemis.de>
Fixed by #3101 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The IResourcesSetupUtil.createTempFile should be overloaded with a signature that accepts not only the fileName, the suffix and the content, but the encoding as well.
This could help to overcome encoding problem within the test cases @hannesN just encountered in a customer project.
The text was updated successfully, but these errors were encountered: