Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

494176: Warning: The file "plugin.xml" does not exist in the workspace #1051

Closed
wants to merge 1 commit into from
Closed

494176: Warning: The file "plugin.xml" does not exist in the workspace #1051

wants to merge 1 commit into from

Conversation

LorenzoBettini
Copy link
Contributor

Now the reference to plugin.xml in the build.properties is not generated by the "Create the Xtext Project from an existing ecore model"

Task-Url: https://bugs.eclipse.org/bugs/show_bug.cgi?id=494176
Signed-off-by: Lorenzo Bettini lorenzo.bettini@gmail.com

@akosyakov
Copy link
Member

please don't merge it

@LorenzoBettini
Copy link
Contributor Author

@akosyakov are there problems with the modifications?

@akosyakov
Copy link
Member

@LorenzoBettini we've already finished testing and it is too minor for testing again, we will merge it after the release

@LorenzoBettini
Copy link
Contributor Author

@akosyakov OK, I see.
I hope you don't mind I had previously merged this other one: #1050

@akosyakov
Copy link
Member

@LorenzoBettini it is fine

@LorenzoBettini
Copy link
Contributor Author

@akosyakov can we merge this now? I seem to understand Xtext 2.10.0 is out :)

@akosyakov
Copy link
Member

@LorenzoBettini generally yes, but we have not had time to review it yet

@dhuebner
Copy link
Contributor

@akosyakov We are in maintenance phase till Neon release. Master is on 2.10.1 now

@LorenzoBettini
Copy link
Contributor Author

@dhuebner so should I do something?

@dhuebner
Copy link
Contributor

dhuebner commented Jun 1, 2016

@LorenzoBettini No. Just wait until Neon is in quite week and we moved the master state to maintenance branch.

@LorenzoBettini
Copy link
Contributor Author

How does it work now that the git repositories are split?

@dhuebner
Copy link
Contributor

You need a PR against a repository you want to contribute.

@LorenzoBettini
Copy link
Contributor Author

@akosyakov @dhuebner This has been reimplemented in the new git repository layout into two PRs: eclipse/xtext-core#29 eclipse/xtext-eclipse#19

@LorenzoBettini
Copy link
Contributor Author

I merged two PRs for this issue in the subprojects, so I'm closing this

eclipse/xtext-core#29
eclipse/xtext-eclipse#22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants