Adapt to new Compilation Participant API in Eclipse 4.28 #2636
Conversation
|
@szarnekow would also be nice if you can give this a try locally |
| * | ||
| * @author dietrich - Initial contribution and API | ||
| */ | ||
| public interface CompilationParticipantExtension { |
There was a problem hiding this comment.
any other idea how to fix "missing override annotations" issues?
There was a problem hiding this comment.
This is a really nice backward compatibility mode.
| private static final Version VERSION_3_34_0 = new Version(3, 34, 0); | ||
|
|
||
| private static Version installedJdtCoreVersion; | ||
| private Set<BuildContext> files; |
There was a problem hiding this comment.
revert this or is set ok?
There was a problem hiding this comment.
BuildContext does not implement equals or hashCode. Should be fine.
|
unfortunately we dont seem to have any tests at all for this |
| * | ||
| * @author dietrich - Initial contribution and API | ||
| */ | ||
| public interface CompilationParticipantExtension { |
There was a problem hiding this comment.
This is a really nice backward compatibility mode.
| private static final Version VERSION_3_34_0 = new Version(3, 34, 0); | ||
|
|
||
| private static Version installedJdtCoreVersion; | ||
| private Set<BuildContext> files; |
There was a problem hiding this comment.
BuildContext does not implement equals or hashCode. Should be fine.
cdietrich
force-pushed
the
cd_testCompilationParticipant2
branch
3 times, most recently
from
92f5bd9
to
fe62b1e
Compare
| workbenchTestHelper.tearDown | ||
| } | ||
|
|
||
| @Test def void testIfThereIsAnyStatum() { |
There was a problem hiding this comment.
@szarnekow what do you think?
| /** | ||
| * @author Christian Dietrich - Initial contribution and API | ||
| */ | ||
| class QuickDebugSourceInstallingCompilationParticipantTest extends AbstractXtendUITestCase { |
There was a problem hiding this comment.
Quick - that's the spirit :)
Fixes #2613 Signed-off-by: Christian Dietrich <christian.dietrich@itemis.de>
cdietrich
force-pushed
the
cd_testCompilationParticipant2
branch
from
fe62b1e
to
743b024
Compare
No description provided.