[xtend generator] Migration of 'ContentAssistFragment'/'JavaBasedContentAssistFragment' #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Schneider <christian.schneider@itemis.de>
| /** | ||
| * Extra getter facilitates customization by overriding. | ||
| */ | ||
| def protected TypeReference getDefaultEObjectLabelProviderSuperClass() { |
There was a problem hiding this comment.
Just a test of reviewers' attention ;-)
…ested in review Signed-off-by: Christian Schneider <christian.schneider@itemis.de>
|
Done with all your suggested improvements. Feel free to have another look! |
| } | ||
|
|
||
|
|
||
| // generation of the 'Abstract...ProposalProvider' |
oehme
added a commit
that referenced
this pull request
Oct 9, 2015
[xtend generator] Migration of 'ContentAssistFragment'/'JavaBasedContentAssistFragment'
| } | ||
|
|
||
| def protected TypeReference getGenProposalProviderSuperClass(Grammar g) { | ||
| val superGrammar = g.nonTerminalsSuperGrammar |
There was a problem hiding this comment.
One minor stylistic, subjective thing: With more involving expressions, an explicit return can often clarify the control flow. See getGenProposalProviderSuperClass and in getFQFeatureNamesToExclude
There was a problem hiding this comment.
Agree. Actually I'm a fan of explicit return statements, but I wasn't sure whether you guys would use it in these cases.
Thanks for that remark :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christian Schneider christian.schneider@itemis.de