Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Original docker build had clear-execstack and stripping - new one does not have #311

Open
matiwinnetou opened this issue Jul 19, 2017 · 5 comments

Comments

@matiwinnetou
Copy link
Contributor

We are getting warnings that J2V8 has been complied without execstack -c.

from original docker docker/Dockerfile.linux:

    execstack -c libj2v8_linux_x86_64.so && \
    echo "striping symbols...." && \
    strip --strip-unneeded -R .note -R .comment libj2v8_linux_x86_64.so && \

@drywolf shall we include this in new build system?

@drywolf
Copy link
Contributor

drywolf commented Jul 19, 2017

shall we include this in new build system?

Yeah, I have a point about it on my todo list. Thanks for mentioning.
I'll give it a higher priority.

@matiwinnetou
Copy link
Contributor Author

@drywolf thanks I may also contribute but now I really want to fix #306 as well, following fixes for #310 and #308.

Docker builds:
Feedback from local folks was that is is probably better to use Ubuntu LTS for building docker images, perhaps there is a way to install cmake 3.6 from ubuntu-backports.

Our warning in PROD:

Java HotSpot(TM) 64-Bit Server VM warning: You have loaded library /mnt/mesos/sandbox/pubse/libj2v8_linux_x86_64.so which might have disabled stack guard. The VM will try to fix the stack guard now.
It's highly recommended that you fix the library with 'execstack -c <libfile>', or link it with '-z noexecstack'.

@drywolf
Copy link
Contributor

drywolf commented Jul 19, 2017

@matiwinnetou Thanks for the hints.
I am currently working on this ... for the part about using Ubuntu LTS ... I am all for it, according to the ubuntu wiki the current LTS release is Xenial, so that's what I would put into the docker files now. CMake would be installed manually again, but I don't see a problem there ... that's how it was in the first place anyway.

@matiwinnetou
Copy link
Contributor Author

matiwinnetou commented Jul 20, 2017

@drywolf Yeah indeed, I have to confess I changed my mind mostly due to issues with linking GCLIB library. We had exception in our integration system where we run debian jessie in our legacy integration system and we ran into linking issues. Previous build system from @irbull was based on Debian Jessie.

Ubuntu 16.04 LTS is already a stretch goal but our new setup with new infrastructure supports docker containers so in theory we can pick newer distrubutions for individual applications.

CMake will have to be sadly installed manually or we find some backport in Ubuntu 16.04 LTS.

Do you know if when using other software like maven we can piggy back on distro's software rather than installing own versions?

@matiwinnetou
Copy link
Contributor Author

matiwinnetou commented Jul 20, 2017

"Stripped and non-stripped symbols for some / all platforms (this reduces the size, but makes debugging harder), I think this should be a configuration param to python script. We probably would not want to strip symbols now because library is not 100% stable yet and it really help to have more debugging info now.

drywolf added a commit to drywolf/J2V8 that referenced this issue Jul 30, 2017
- register atexit events before cross-builds are started
- switched linux & android docker images to Ubuntu Xenial LTS (see eclipsesource#311)
- cleaned up and documented switch-to-winrm-plugin that is used in win32:vagrant builds
drywolf added a commit to drywolf/J2V8 that referenced this issue Jul 30, 2017
- register atexit events before cross-builds are started
- switched linux & android docker images to Ubuntu Xenial LTS (see eclipsesource#311)
- cleaned up and documented switch-to-winrm-plugin that is used in win32:vagrant builds
matiwinnetou pushed a commit to matiwinnetou/J2V8 that referenced this issue Aug 16, 2017
- register atexit events before cross-builds are started
- switched linux & android docker images to Ubuntu Xenial LTS (see eclipsesource#311)
- cleaned up and documented switch-to-winrm-plugin that is used in win32:vagrant builds
irbull pushed a commit that referenced this issue Aug 28, 2017
- register atexit events before cross-builds are started
- switched linux & android docker images to Ubuntu Xenial LTS (see #311)
- cleaned up and documented switch-to-winrm-plugin that is used in win32:vagrant builds
irbull pushed a commit that referenced this issue Aug 29, 2017
- register atexit events before cross-builds are started
- switched linux & android docker images to Ubuntu Xenial LTS (see #311)
- cleaned up and documented switch-to-winrm-plugin that is used in win32:vagrant builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants