TryCatch: It is more thread safe to use isolate passed explicitly rather than relying on it retrieved via a static call in constructor. #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er than relying on it retrieved via a static call in constructor.
matiwinnetou
force-pushed
the
fix-issue-307
branch
from
e9cf034
to
33c83f0
Compare
|
We were running stress tests over the whole night in production and it seems the issue disappears with this FIX. |
matiwinnetou
changed the title
matiwinnetou
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #307. Perhaps there is more elegant fix but this already helps us in production on multi concurrent access and our rendering pool from V8s to serve pages.