Skip to content

Commit

Permalink
dev: Update Node version to 18.19+
Browse files Browse the repository at this point in the history
- Adapt README
- Update node versions for CI, Netlify, dev container
- Update @types/node dependencies to ^18.19.4
  • Loading branch information
lucas-koehler committed Jan 3, 2024
1 parent c2836a5 commit 7f0f672
Show file tree
Hide file tree
Showing 12 changed files with 27 additions and 31 deletions.
4 changes: 2 additions & 2 deletions .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# See here for image contents: https://github.com/microsoft/vscode-dev-containers/tree/v0.191.1/containers/javascript-node/.devcontainer/base.Dockerfile

# [Choice] Node.js version: 16
ARG VARIANT="16"
# [Choice] Node.js version: 18
ARG VARIANT="18"
FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:1-${VARIANT}

# Install chromium and point the CHROME_BIN environment variable to it
Expand Down
4 changes: 2 additions & 2 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
"name": "Node.js",
"build": {
"dockerfile": "Dockerfile",
// Update 'VARIANT' to pick a Node version: 16
// Update 'VARIANT' to pick a Node version: 18
"args": {
"VARIANT": "16"
"VARIANT": "18"
}
},
// Set *default* container specific settings.json values on container create.
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18

- uses: pnpm/action-setup@v2.2.4
name: Install pnpm
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
- name: "Setup node"
uses: "actions/setup-node@v3"
with:
node-version: "16"
node-version: "18"
registry-url: "https://registry.npmjs.org"

- uses: "pnpm/action-setup@v2.2.4"
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v16.20.1
v18.19.0
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ See our [migration guide](https://github.com/eclipsesource/jsonforms/blob/master

### First time setup

- Install [node.js](https://nodejs.org/) (only Node v16.13+ < 17 is currently supported)
- Install [node.js](https://nodejs.org/) (only Node v18.19+ < 19 is currently supported)
- Install pnpm: <https://pnpm.io/installation> (use pnpm 8.6.2+)
- Clone this repository
- Install dependencies: `pnpm i --frozen-lockfile`
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "jsonforms-monorepo",
"engines": {
"node": "^16.14",
"node": "^18.19.0",
"pnpm": ">=7.13.4"
},
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/angular-material/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
"@rollup/plugin-replace": "^5.0.1",
"@types/jasmine": "~3.8.0",
"@types/lodash": "4.14.149",
"@types/node": "^18.10.0",
"@types/node": "^18.19.4",
"@typescript-eslint/eslint-plugin": "^5.54.1",
"@typescript-eslint/parser": "^5.54.1",
"babel-loader": "^8.0.6",
Expand Down
2 changes: 1 addition & 1 deletion packages/examples/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
},
"devDependencies": {
"@jsonforms/core": "workspace:*",
"@types/node": "^16.18.34",
"@types/node": "^18.19.4",
"@typescript-eslint/eslint-plugin": "^5.54.1",
"@typescript-eslint/parser": "^5.54.1",
"eslint": "^7.32.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/vue-vanilla/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"@types/chai": "^4.2.11",
"@types/jest": "^27.4.1",
"@types/mocha": "^5.2.4",
"@types/node": "^16.18.34",
"@types/node": "^18.19.4",
"@typescript-eslint/eslint-plugin": "^5.54.1",
"@typescript-eslint/parser": "^5.54.1",
"@vue/cli-plugin-babel": "~4.5.19",
Expand Down
2 changes: 1 addition & 1 deletion packages/vue/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"@jsonforms/core": "workspace:*",
"@rollup/plugin-alias": "^3.1.8",
"@types/jest": "^27.4.1",
"@types/node": "^16.18.34",
"@types/node": "^18.19.4",
"@typescript-eslint/eslint-plugin": "^5.54.1",
"@typescript-eslint/parser": "^5.54.1",
"@vue/cli-plugin-babel": "~4.5.19",
Expand Down
32 changes: 14 additions & 18 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 7f0f672

Please sign in to comment.