Fix Selection in ListWithDetail Renderer #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests seem to fail because of the the missing |
eneufeld
force-pushed
the
fix/angular-material
branch
from
15563de
to
957942d
Compare
* The layout renderer always provided the same rendererProps to the jsonforms-outlet independent of the input changes. To not rerender the layout on any change we need to fix the ngFor, as we can't provide an useful trackBy function we reuse the array. * The master-detail.service is unnecessary as we fixed the disposal. * The master part didn't refresh item labels on changes in detail, thus added the track by.
eneufeld
force-pushed
the
fix/angular-material
branch
from
957942d
to
e8f6157
Compare
|
pushed fixed test case and updated commit message |
edgarmueller
approved these changes
Nov 15, 2018
edgarmueller
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to the jsonforms-outlet independent of the input changes.
To not rerender the layout on any change we need to fix the ngFor,
as we can't provide an useful trackBy function we reuse the array.
thus added the track by.