Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide all react / material controls #1304

Merged
merged 1 commit into from Mar 21, 2019
Merged

Hide all react / material controls #1304

merged 1 commit into from Mar 21, 2019

Conversation

sdirix
Copy link
Member

@sdirix sdirix commented Mar 21, 2019

  • Make sure all controls are hideable (react / material)
  • Add corresponding tests where they were missing

Fixes #1280

@sdirix sdirix force-pushed the hide-controls branch 2 times, most recently from 9b1708e to 953cf43 Compare March 21, 2019 12:48
@sdirix
Hide all react / material controls
8d2639e 
 * Make sure all controls are hideable (react / material)
 * Add corresponding tests where they were missing
 * Add example combining rules and options
@sdirix sdirix marked this pull request as ready for review March 21, 2019 12:51
@coveralls
Copy link

coveralls commented Mar 21, 2019 •
edited

Coverage Status

Coverage increased (+0.6%) to 89.806% when pulling 8d2639e on sdirix:hide-controls into 7b7cfb0 on eclipsesource:master.

@edgarmueller edgarmueller requested review from eneufeld and removed request for edgarmueller March 21, 2019 16:41
eneufeld
eneufeld approved these changes Mar 21, 2019
View reviewed changes
Copy link
Member

@eneufeld eneufeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good tests!
We should check for cases where we do the hiding our self by using a custom css style instead of the Hidden element of MUI. But this should not be part of this PR.

@eneufeld eneufeld merged commit 378a3f4 into eclipsesource:master Mar 21, 2019
@edgarmueller edgarmueller added this to the 2.2.2 milestone Mar 22, 2019
@edgarmueller edgarmueller mentioned this pull request Apr 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eneufeld eneufeld eneufeld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sdirix @coveralls @eneufeld @edgarmueller