Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Readonly utility function #1371

Merged
merged 2 commits into from
May 17, 2019
Merged

Add Readonly utility function #1371

merged 2 commits into from
May 17, 2019

Conversation

eneufeld
Copy link
Member

  • Add support for angular renderers
  • Add button to set/unset readonly in example

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 84.618% when pulling 43a1277 on eneufeld:feat/readonly into 93e5577 on eclipsesource:master.

@eneufeld eneufeld mentioned this pull request May 15, 2019
Merged
edgarmueller
edgarmueller reviewed May 17, 2019
View reviewed changes
Copy link
Contributor

@edgarmueller edgarmueller left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, but when I select the 'day 1' example and click the 'Set readonly' button, the form disappears and also does not pop up again when clicking the 'Unset readonly' button. Any idea why?

packages/core/src/util/uischema.ts Outdated Show resolved Hide resolved
packages/core/src/models/uischema.ts Outdated Show resolved Hide resolved
@edgarmueller edgarmueller added this to the 2.3.0 milestone May 17, 2019
@eneufeld
Add Readonly utility function
fe4d672 
* Add support for angular renderers
* Add button to set/unset readonly in example
@eneufeld
Fixed Review Comments
6434cbe
edgarmueller
edgarmueller approved these changes May 17, 2019
View reviewed changes
Copy link
Contributor

@edgarmueller edgarmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected now, thanks

@edgarmueller edgarmueller merged commit 2abb9c7 into eclipsesource:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgarmueller edgarmueller edgarmueller approved these changes

Assignees
No one assigned
Labels
angular core
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@eneufeld @coveralls @edgarmueller