Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated dependency on react-addons-shallow-compare #36

Closed
KirilOkun opened this issue Apr 17, 2017 · 2 comments
Closed

Deprecated dependency on react-addons-shallow-compare #36

KirilOkun opened this issue Apr 17, 2017 · 2 comments
Labels
enhancement

Comments

@KirilOkun
Copy link

According to https://www.npmjs.com/package/react-addons-shallow-compare react-addons-shallow-compare has been deprecated in favor of React.PureComponent. When do you think you'll be able to refactor react-times to use it?
Thanks in advance.
@ecmadao
Copy link
Owner

ecmadao commented Apr 17, 2017

@bearoutthere
Cool. Right now.
By the way, actually I don't use react-addons-shallow-compare, but I will use React.PureComponent now, THX!

@ecmadao
Copy link
Owner

ecmadao commented Apr 17, 2017

@bearoutthere
v1.4.5 published, using PureComponent.

@ecmadao ecmadao closed this as completed Apr 17, 2017
@ecmadao ecmadao mentioned this issue Apr 17, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KirilOkun @ecmadao