Functional Solvers #1395
Merged
Functional Solvers #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1395 +/- ##
==========================================
- Coverage 71.72% 70.56% -1.16%
==========================================
Files 84 84
Lines 13910 14305 +395
==========================================
+ Hits 9977 10095 +118
- Misses 3933 4210 +277 ☔ View full report in Codecov by Sentry. |
15 tasks
3 tasks
|
@mnwhite updated |
alanlujan91
added
the
Ready-To-Merge
|
@mnwhite added docstrings and merging as discussed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some suggestions for @mnwhite's ongoing solver overhaul.
Simple functions that can be re-used within a "family" of models, but should not be expected to "jump" out of their own file.