example: function call within assert

[psychocoderHPC]

I checked your library and looked into your test case to get a feeling of how your library should be used.
The test is using the pattern assert(VELOC_*()), this is dangerous because in cases where the code will be compiled with -DNDEBUG the function call within assert will not be executed because assert () is a noop.

example:

VELOC/test/heatdis_fault.cpp

Line 123 in 4a8ec34

assert(VELOC_Restart("heatdis", v) == VELOC_SUCCESS);

VELOC/test/heatdis_fault.cpp

Line 138 in 4a8ec34

assert(VELOC_Checkpoint("heatdis", i) == VELOC_SUCCESS);

I know that the code I pointed to is the test case of VELOC but users will most likely start with copy-pasting from existing code and therefore propagate the issue into their own codebase.

[bnicolae]

Thanks for the feedback. Indeed, the intention was to make the example succinct, rather than a recommendation of how to use VELOC in production. We will fix this.

[bnicolae]

Done, updated examples are now available