feat(datepicker) New input pickerInitialDate

[harogaston]

• New input (optional) that sets the intial date to display (null = today)
• Updated demo page

Partially addresses #165

Before submitting a pull request, please make sure you have at least performed the following:

• read and followed the CONTRIBUTING.md guide.
• linted, built and tested the changes locally.
• added/updated any applicable API documentation.
• added/updated any applicable demos.

[edcarroll]

Thanks @harogaston, will get this looked at and merged hopefully tomorrow 😄

[edcarroll]

Thank you for looking at this issue 😄 comments outline a simpler way of doing this, already built into the datepicker - will merge once changed to use that :)

[edcarroll]

Rather than going this way, make use of the pre existing currentDate property of the CalendarService.

In the datepicker directive, add the following just before you set the service selected date:

this.componentInstance.service.currentDate = this.initialDate || new Date()

Then in the calendar service, change reset to something like:

public reset():void {
    this.currentView = this.config.mappings.finalView;

    if (!this._selectedDate) {
        let current = this.currentDate.getTime();
        if (this._minDate) {
            current = Math.max(current, this._minDate.getTime());
        }
        if (this._maxDate) {
            current = Math.min(current, this._maxDate.getTime());
        }

        this.currentDate = new Date(current);
        this.config.updateBounds(this.currentDate);

        this.currentView = this.config.mappings.initialView;
    }
}

That should do the trick without needing to do any null checks etc 😄

[harogaston]

The thing is, as I imagined it, that if [pickerInitialDate] was set, that meant that the input should be pre populated (i.e. this._selectedDate set) with the given date, or today() if null was passed, or do nothing (i.e. same as previous behavior) if [pickerInitialDate] was not used or was undefined.

Your proposal only concerns with the date the user will see when opening the pop up. Which is also interesting. Which way to go?

I personally think that if we allow for an pickerInitialDate that date should be selected. But it is just preference/semantics.

PS: Nevertheless, the code could still be improved.

[edcarroll]

Change to Sets the intial date to display when no date is selected.. Add new Date() as the defaultValue

[harogaston]

Gotcha (but also read bottom comment)

[harogaston]

Some thoughts.

Regarding new Date() as the defaultValue and considering what I mentioned before: Maybe the intended behavior it was not clear. As I implemented it, there is a difference between

• [pickerInitialDate]="null" means: initial date is today
• [pickerInitialDate] not present or undefined means: do nothing (same old behavior)
• [pickerInitialDate]="dateObject" means: set dateObject as the selected date (the input will be populated!)

That was my idea. Maybe we should get to an agreement regarding the expected behavior before we do anything else.

[edcarroll]

On those bullets:

1 & 2: the old behavior is new Date() but bounded to possible values, i.e. inside the min & max date range. This means that you don't get the datepicker into a ridiculous range if your min & max are waaaay in the past / future, but also you don't need to configure it.
3: In that case, why not just use pickerSelectedDate? Having this initial date property set a selected date is very confusing - do we then emit that date in ngModel? I don't like the idea of two separate properties essentially conflicting with eachother.

Do you see what I mean?

[harogaston]

I'm sorry, you are absolutely right. I was confused. I'll get onto it this weekend!

[harogaston]

Just did what you suggested. Sorry about the confusion.

Should I have merged new changes from master before this commit?

[edcarroll]

Minor points, literally 30 second fixes. Will merge as soon as that's done 😄

[edcarroll]

Unnecessary?

[harogaston]

Yes, just went unnoticed by the analyzer, idk.

[edcarroll]

So the unused imports option is currently disabled because it's super unreliable... So just trying to delete things when I see them really until the analyzer is fixed.

[edcarroll]

Set currentDate to new Date() in the constructor, and make this line just this.currentDate.getTime() since currentDate isn't nullable.

[edcarroll]

Just to make it look a bit nicer

[edcarroll]

Looks good! 💃