fix: Added custom FocusEvent interface #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #202 FocusEvent isn't defined in UC browser, so added IFocusEvent with the property we need.
mcosta74
reviewed
Aug 11, 2017
|
In the original issue I uploaded a test build that did essentially what this PR does, which is remove all references to FocusEvent. So, this has been tested and should be ok 😄 |
mcosta74
approved these changes
Aug 11, 2017
mcosta74
pushed a commit
that referenced
this pull request
Aug 14, 2017
* fix: Fixed AOT on SystemJS builder Closes #209 * fix: Added custom FocusEvent interface (#231) * fix: Added custom FocusEvent interface Closes #202 FocusEvent isn't defined in UC browser, so added IFocusEvent with the property we need. * style(util): Fixed tslint error * chore(popup): Relaxed popper.js dependency (#228) Follows up on #195 * fix(popup): Fixed delay causing destroyed view errors (#233) Closes #189 * fix(select): Manually run change detector when option updates (#236) * fix(select): Manually run change detector when option updates Closes #213 * style(select): Fixed tslint error * fix(select): Selected options now updated when options change (#232) * fix(modal): Fixed aggressive autofocus sometimes causing errors (#237) * fix(popup): Fixed conflict with BrowserAnimationsModule (#234) * fix(popup): Fixed conflict with BrowserAnimationsModule Closes #204 * style(popup): Fixed tslint error * feat(popup): Added template context support (#238) * fix(popup): Fixed focus events on popup (#243) * feat(datepicker) Popup now honors locale and pickerLocaleOverrides (#215) * Datepicker popup now honors locale and pickerLocaleOverrides - Datepicker popup items now respect locale format - Fixed a bug in zoom calendar mapping for datetime datepicker - Fixed 'es' locale for consistency (*) Partially addresses #164 * Added comments. * Time of day values supported in locale definitions (#214) * en-GB and en-US locales now use 12 hour format Original "HH:mm" (23:59) -> Now "hh:mm aa" (11:59 p.m.) * Fix locales Russian, Italian and Hebrew now extend from ILocaleValues. * Added new IDatepickerFormatsLocaleValues fields: - timesOfDay - timesOfDayUppercase - timesOfDayLowercase to support proper formatting/parsing of dates in datepicker. Updated Localization page * Fixing code formatting * feat(datepicker) Added initial date support for the datepicker (#216) * feat(datepicker) New input pickerInitialDate - New input (optional) that sets the intial date to display (null = today) - Updated demo page Partially addresses #165 * Now pickerInitialDate only sets CalendarService.currentDate property * feat(datepicker): Initial date support - Code formatting * fix: Various minor bugfixes (#245) * fix(select): Fixed destroyed view errors * fix(modal): Fix modal auto closing when clicked * fix(popup): Removed console log in focus handler * fix(popup): Forced import of TemplateRef * fix: Fixed AOT on SystemJS builder Closes #209
gotenxds
pushed a commit
to gotenxds/ng2-semantic-ui
that referenced
this pull request
Aug 15, 2017
* fix: Added custom FocusEvent interface Closes edcarroll#202 FocusEvent isn't defined in UC browser, so added IFocusEvent with the property we need. * style(util): Fixed tslint error
gotenxds
pushed a commit
to gotenxds/ng2-semantic-ui
that referenced
this pull request
Aug 15, 2017
* fix: Fixed AOT on SystemJS builder Closes edcarroll#209 * fix: Added custom FocusEvent interface (edcarroll#231) * fix: Added custom FocusEvent interface Closes edcarroll#202 FocusEvent isn't defined in UC browser, so added IFocusEvent with the property we need. * style(util): Fixed tslint error * chore(popup): Relaxed popper.js dependency (edcarroll#228) Follows up on edcarroll#195 * fix(popup): Fixed delay causing destroyed view errors (edcarroll#233) Closes edcarroll#189 * fix(select): Manually run change detector when option updates (edcarroll#236) * fix(select): Manually run change detector when option updates Closes edcarroll#213 * style(select): Fixed tslint error * fix(select): Selected options now updated when options change (edcarroll#232) * fix(modal): Fixed aggressive autofocus sometimes causing errors (edcarroll#237) * fix(popup): Fixed conflict with BrowserAnimationsModule (edcarroll#234) * fix(popup): Fixed conflict with BrowserAnimationsModule Closes edcarroll#204 * style(popup): Fixed tslint error * feat(popup): Added template context support (edcarroll#238) * fix(popup): Fixed focus events on popup (edcarroll#243) * feat(datepicker) Popup now honors locale and pickerLocaleOverrides (edcarroll#215) * Datepicker popup now honors locale and pickerLocaleOverrides - Datepicker popup items now respect locale format - Fixed a bug in zoom calendar mapping for datetime datepicker - Fixed 'es' locale for consistency (*) Partially addresses edcarroll#164 * Added comments. * Time of day values supported in locale definitions (edcarroll#214) * en-GB and en-US locales now use 12 hour format Original "HH:mm" (23:59) -> Now "hh:mm aa" (11:59 p.m.) * Fix locales Russian, Italian and Hebrew now extend from ILocaleValues. * Added new IDatepickerFormatsLocaleValues fields: - timesOfDay - timesOfDayUppercase - timesOfDayLowercase to support proper formatting/parsing of dates in datepicker. Updated Localization page * Fixing code formatting * feat(datepicker) Added initial date support for the datepicker (edcarroll#216) * feat(datepicker) New input pickerInitialDate - New input (optional) that sets the intial date to display (null = today) - Updated demo page Partially addresses edcarroll#165 * Now pickerInitialDate only sets CalendarService.currentDate property * feat(datepicker): Initial date support - Code formatting * fix: Various minor bugfixes (edcarroll#245) * fix(select): Fixed destroyed view errors * fix(modal): Fix modal auto closing when clicked * fix(popup): Removed console log in focus handler * fix(popup): Forced import of TemplateRef * fix: Fixed AOT on SystemJS builder Closes edcarroll#209
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #202
FocusEvent isn't defined in UC browser, so added IFocusEvent with the property we need.