Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footnote problem in the sample letter #8

Closed
jameshunterbr opened this issue Oct 23, 2017 · 4 comments
Closed

Footnote problem in the sample letter #8

jameshunterbr opened this issue Oct 23, 2017 · 4 comments

Comments

@jameshunterbr
Copy link

I tried your sample letter, which worked fine, except that it did not render the footnote in your original.
I am sending a copy of the print of the test.
test_letter.pdf
Also the R Markdown file that generated it.
test letter2.Rmd.txt
--Jim Hunter

@aaronwolen
Copy link
Collaborator

The links-as-notes variable is enabled in the README screen capture (right after the signature block) but is off by default.

Assuming most letters will be printed, this should probably be enabled by default. What do you think @eddelbuettel?

@eddelbuettel
Copy link
Owner

I am confused. I just re-ran the vignette yesterday, and it has it. Recall that README.md has two screen captures (skeleton and vignette) and they do correspond to 0.0.1.2 (ie 0.0.2 to be).

Are we looking at a 0.0.1 (as on CRAN) vs 0.0.1.2 (as on GH) difference? Or as you say, a different (missing) default? Or is not enabling a "wanted" feature a user error?

@aaronwolen
Copy link
Collaborator

aaronwolen commented Oct 23, 2017

You're right. It's only present in the vignette, which is the expected behavior.

For the next release I'm proposing we add it the list of features in #2 that are set by default.

@eddelbuettel
Copy link
Owner

Closing this -- I am sorry about the 'version on CRAN and actual behaviour' difference, but it was CRAN that sat on the submission.

If you read README.md now (or as of yesterday) you see how to get 0.0.1.2 which is the currently closest to an upcoming 0.0.2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants