Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BA_GEST is not recognized as Zusatzmodul #50

Closed
1 of 4 tasks
TheHuebschi opened this issue Feb 18, 2020 · 1 comment · Fixed by #53
Closed
1 of 4 tasks

BA_GEST is not recognized as Zusatzmodul #50

TheHuebschi opened this issue Feb 18, 2020 · 1 comment · Fixed by #53
Labels
module-mapping Modules that are not mapped or wrongly mapped to a type

Comments

@TheHuebschi
Copy link

TheHuebschi commented Feb 18, 2020 •
edited by Lextum
Loading

What do you study?

  • Informatik
  • Security
  • Wirtschaftsinformatik
  • Digital Ideation

Which modules are not recognized by the add-on? And what type should they have?

  • BA_GEST (Zusatzmodul)

Screenshots
grafik

More info
@TheHuebschi TheHuebschi added the module-mapping Modules that are not mapped or wrongly mapped to a type label Feb 18, 2020
@eddex
Copy link
Owner

eddex commented Feb 18, 2020 •
edited
Loading

Thanks for reporting this issue!

The problem is in the module_parser due to a conflict with other special cases where the module name contains an underscore:

hslu-simple-mep-results/src/components/module_parser.js

Line 101 in 16363e0

if (name.includes('_')) {

EDIT: The problem is not in the parser but in the parse_module_type.py script. The prefix 'BA_ has not been removed:

hslu-simple-mep-results/tools/parse_module_type.py

Line 189 in 16363e0

modules_with_type['BA_GEST'] = zusatzmodul

This was referenced Feb 18, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module-mapping Modules that are not mapped or wrongly mapped to a type
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

release 2.0.14 eddex/hslu-simple-mep-results
2 participants
@eddex @TheHuebschi