Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tab completion and fancy prompt to Git #4

Closed
bittner opened this issue Sep 8, 2017 · 2 comments
Closed

Add tab completion and fancy prompt to Git #4

bittner opened this issue Sep 8, 2017 · 2 comments

Comments

@bittner
Copy link
Contributor

bittner commented Sep 8, 2017

Would you be interested to have two additional features added to the Git class?

Using this could look like this:

  class { 'software::vcsscm::git':
    ensure          => present,
    bash_completion => true,
    bash_prompt     => true,
    gui             => true,
  }

bash_* because: it really just relates to Bash, and would be difficult to generically implement this for several shells (in an "autodetect shell" way).

If you think that would be a good addition, I would open a PR for that. Though, I would (have to) limit my contribution to a Debian/Ubuntu implementation. No Mac, no Windows, for now.

@edestecd
Copy link
Owner

edestecd commented Sep 9, 2017

Yes, I was actually going to add the tab completion myself for osx soon. As long as its optional, i'm not against any new feature.

@edestecd
Copy link
Owner

edestecd commented Sep 9, 2017

The example you have looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants