Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use latest typing features where possible #918

Merged
merged 3 commits into from
Aug 2, 2023

Conversation

edgarrmondragon
Copy link
Owner

@edgarrmondragon edgarrmondragon commented Aug 2, 2023


📚 Documentation preview 📚: https://citric--918.org.readthedocs.build/en/918/

@trunk-io
Copy link

trunk-io bot commented Aug 2, 2023

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3404b23) 100.00% compared to head (ed7eac3) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #918   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          405       403    -2     
  Branches        23        23           
=========================================
- Hits           405       403    -2     
Files Changed Coverage Δ
src/citric/client.py 100.00% <100.00%> (ø)
src/citric/session.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@edgarrmondragon edgarrmondragon marked this pull request as ready for review August 2, 2023 21:58
@edgarrmondragon edgarrmondragon merged commit c886663 into main Aug 2, 2023
31 checks passed
@edgarrmondragon edgarrmondragon deleted the ci/check-types branch August 2, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant