Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Client.get_server_version #944

Merged
merged 6 commits into from
Aug 23, 2023
Merged

Conversation

edgarrmondragon
Copy link
Owner

@edgarrmondragon edgarrmondragon commented Aug 23, 2023


📚 Documentation preview 📚: https://citric--944.org.readthedocs.build/en/944/

@trunk-io
Copy link

trunk-io bot commented Aug 23, 2023

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b11cf88) 100.00% compared to head (2ec4aea) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #944   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          420       422    +2     
  Branches        22        22           
=========================================
+ Hits           420       422    +2     
Files Changed Coverage Δ
src/citric/client.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@edgarrmondragon edgarrmondragon marked this pull request as ready for review August 23, 2023 04:31
@edgarrmondragon edgarrmondragon added enhancement New feature or request RPC Issues related to the RPC client implementation labels Aug 23, 2023
@edgarrmondragon edgarrmondragon merged commit 937c8d8 into main Aug 23, 2023
26 of 34 checks passed
@edgarrmondragon edgarrmondragon deleted the feat/get-server-version branch August 23, 2023 04:32
@edgarrmondragon edgarrmondragon self-assigned this Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request RPC Issues related to the RPC client implementation
Projects
Development

Successfully merging this pull request may close these issues.

1 participant