-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition to eslint #1020
Closed
Closed
Transition to eslint #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotttrinh
requested changes
May 14, 2024
We also want to:
|
scotttrinh
reviewed
May 21, 2024
scotttrinh
reviewed
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: I suggest reviewing commit by commit.
I added the config (eslint.config) for eslint v9 with flat config.
I fixed majority of errors throughout the codebase. And hopefully
any
types in Remix auth lib.But definitely a good review is needed of the changes I made.
And there are some errors I wasn't sure about how to fix and also many other any type warnings.
I left todo comments somewhere where I wasn't sure if my "fix" is good enough.
More info: here are
ts-eslint
recommended rules,
recommended-type-checked rules,
strict,
strict-type-checked,
stylistic,
stylistic-type-checked.
EDIT:
I removed stylistic "@typescript-eslint/class-literal-property-style" rule because it is enforcing
readonly field
class literal values, and we use getters in many places (which is actually safer).TODO:
Check
packages/generate/src/syntax/castMaps.ts
. Not sure what's this file and how to fix it.