Fix named-tuple params that also appear in the schema #5964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tuple argument decoder code simply ignores whether a tuple is named, figuring that named tuples and unnamed tuples have the same representation in the generated SQL, so why bother. (It was called out as a "HACK" in the comments.) But they only have the same representation when they are represented as a `record`. If the tuple type appears in the schema, it gets represented as a named composite type and we no longer have the right representation. Just do it right. Fixes #5789.
elprans
approved these changes
Aug 26, 2023
aljazerzen
approved these changes
Aug 28, 2023
msullivan
added a commit
that referenced
this pull request
Sep 2, 2023
The tuple argument decoder code simply ignores whether a tuple is named, figuring that named tuples and unnamed tuples have the same representation in the generated SQL, so why bother. (It was called out as a "HACK" in the comments.) But they only have the same representation when they are represented as a `record`. If the tuple type appears in the schema, it gets represented as a named composite type and we no longer have the right representation. Just do it right. Fixes #5789.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tuple argument decoder code simply ignores whether a tuple is
named, figuring that named tuples and unnamed tuples have the same
representation in the generated SQL, so why bother. (It was called out
as a "HACK" in the comments.)
But they only have the same representation when they are represented
as a
record. If the tuple type appears in the schema, it getsrepresented as a named composite type and we no longer have the right
representation.
Just do it right. Fixes #5789.