Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix named-tuple params that also appear in the schema #5964

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Fix named-tuple params that also appear in the schema #5964

merged 1 commit into from
Aug 30, 2023

Commits on Aug 26, 2023

  1. Fix named-tuple params that also appear in the schema 

    The tuple argument decoder code simply ignores whether a tuple is
named, figuring that named tuples and unnamed tuples have the same
representation in the generated SQL, so why bother. (It was called out
as a "HACK" in the comments.)

But they only have the same representation when they are represented
as a `record`. If the tuple type appears in the schema, it gets
represented as a named composite type and we no longer have the right
representation.

Just do it right. Fixes #5789.
    @msullivan
    msullivan committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    4cee072 View commit details
    Browse the repository at this point in the history