Skip to content
This repository has been archived by the owner on Apr 16, 2023. It is now read-only.

[SDCARD] SD cards without labels #10

Closed
pfeerick opened this issue Jun 26, 2021 · 2 comments
Closed

[SDCARD] SD cards without labels #10

pfeerick opened this issue Jun 26, 2021 · 2 comments

Comments

@pfeerick
Copy link
Member

I think a side effect of this test is that SD cards that haven't had a label set won't appear in the drop down? I can understand the mounted part, that's part and parcel of doing stuff on Linux, but requiring a label is going to be annoying unless the requirement is clearly stated. i.e. I never bothered setting a volume label for the SD that came with my T-Lite, and it didn't appear in the list - so I just had to set one after reviewing the code to work out why it didn't show. I can't say for certain I noticed the problem on Windows - I'll have to try again with another unlabelled card to check.

return el.removable && (el.label != "") && (el.mount != "")

@pfeerick pfeerick changed the title [SDCARD] SD cards with labels (possibly Linux specific) [SDCARD] SD cards without labels (possibly Linux specific) Jun 26, 2021
@pfeerick pfeerick changed the title [SDCARD] SD cards without labels (possibly Linux specific) [SDCARD] SD cards without labels Jun 27, 2021
@pfeerick
Copy link
Member Author

Just verified it's also happening on Windows, so it will be because of that filter. It may be better to drop that requirement, and possibly also add the size of the drive to the dropdown, thus if a system drive is included in the list by accident (which generally shouldn't because of the removable requirement, the end user can eliminate by size.

@CoderElectronics
Copy link
Collaborator

The filter has been removed so it should work fine now, please re-open if it wasn't solved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants