Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Enhance ManagedRule to use singular naming and reference GeneralSettings in ManagedRule #47

Closed
wdawg33 opened this issue Aug 13, 2021 · 0 comments · Fixed by #48
Closed

[Feature Request] Enhance ManagedRule to use singular naming and reference GeneralSettings in ManagedRule #47

wdawg33 opened this issue Aug 13, 2021 · 0 comments · Fixed by #48
Labels
enhancement New feature or request

Comments

@wdawg33
Copy link
Collaborator

wdawg33 commented Aug 13, 2021

Describe the solution you'd like
ManagedRule has DisabledRules and RuleTargetUpdates. These arrays should hold collections of DisabledRule and RuleTargetUpdate types instead of the plural form.

GeneralSettings is embedded into ManagedRule but should instead be included as a single field.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Managed Rule Enhancements and Fix for updateAccessRule example Edgio/ec-sdk-go
1 participant
@wdawg33