Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've had some pretty bad crashes from this (bringing down the entire verk application), and the root cause is from
System.stracktrace
here returning a stacktrace like{GenServer, :call, [:my_named_process, \"1\", 5000]}
.Verk eventually attempts to format with
Exception.format_stacktrace/1
here, which doesn't work since that callsEnum.map_join
, and a tuple isn't Enumerable.A contrived example of a worker that causes this:
I added a test that will fail without my changes:
Beyond it's impact on verk here, I'm not sure if it's considered an Elixir issue that
System.stacktrace
may return something not necessarily formattable.